-
Notifications
You must be signed in to change notification settings - Fork 83
Add new settings to support custom endpoints in Azure COSI #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| == Cloud storage integration settings | ||
|
|
||
| Configuration settings are used for custom cloud storage and host authority endpoints, enabling support for non-public and private cloud Azure deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These settings will be available in 5.26.4 and 2025.03. Is this true?
If it's true, I want to label them 'Available in 5.26.4' not 'Introduced in 5.26.4'. Because when we use Introduced in ... label this implies that a feature is available in all later versions. However, in this case settings are not available in 2025.01 and 2025.02 releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
fabiim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but I think we should add more colour to one of the descriptions
| [frame="topbot", stripes=odd, grid="cols", cols="<1s,<4"] | ||
| |=== | ||
| |Description | ||
| a|Azure blob storage endpoint suffix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have added a bit more detail in the code. Something like :
Azure blob storage endpoint suffix. You will need to change this if you aren't using Azure public cloud (e.g., if you are using Azure Government)
|
|
||
| == Cloud storage integration settings | ||
|
|
||
| Configuration settings are used for custom cloud storage and host authority endpoints, enabling support for non-public and private cloud Azure deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
|
This PR includes documentation updates Updated pages: |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
No description provided.